Net 6529 Gatewayclassconfig CRD #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahalsmiller
added
pr/no-changelog
sarahalsmiller
force-pushed
the
NET-6529-gateway-class-config-crd
branch
from
5b07d3f
to
b861051
Compare
missylbytes
approved these changes
Nov 16, 2023
t-eckert
reviewed
Nov 20, 2023
| shortNames: | ||
| - gateway-class-config | ||
| singular: gatewayclassconfig | ||
| scope: Namespaced |
There was a problem hiding this comment.
I think we wanted this to be Cluster-scoped. We just now realized this. Will you add the following annotation to the GatewayClassConfig? // +kubebuilder:resource:scope=Cluster
sarahalsmiller
force-pushed
the
NET-6529-gateway-class-config-crd
branch
from
b861051
to
1eea090
Compare
t-eckert
approved these changes
Nov 21, 2023
sarahalsmiller
added a commit
that referenced
this pull request
Jan 5, 2024
* CRD file gneration * update to cluster scope * cluster scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: